Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fixes from v3 #213

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Backport fixes from v3 #213

merged 3 commits into from
Oct 21, 2021

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Oct 21, 2021

  • Fixed: #179 DualFromZeroToTwo plural rule. Thanks to @OhSoGood
  • Fixed: #211 Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException. Thanks to @bogatykh

@axunonb
Bumped version to 2.7.1
365bbd0 
Backported bug fixes from v3.0.0-alpha:
axuno#179 - Corrected DualFromZeroToTwo plural rule
axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException
@axunonb
Revert "Bumped version to 2.7.1"
6620d7f 
This reverts commit 365bbd0.
@axunonb
Backported bug fixes from v3.0.0-alpha
4430987 
axuno#179 - Corrected DualFromZeroToTwo plural rule
axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #213 (e65f04d) into main (3165fc7) will not change coverage.
The diff coverage is 100%.

❗ Current head e65f04d differs from pull request most recent head 4430987. Consider uploading reports for the commit 4430987 to get more accurate results
Impacted file tree graph

@@         Coverage Diff         @@
##           main   #213   +/-   ##
===================================
  Coverage    94%    94%           
===================================
  Files        42     42           
  Lines      1749   1749           
===================================
  Hits       1651   1651           
  Misses       98     98
Impacted Files Coverage Δ
src/SmartFormat/Core/Parsing/Parser.cs 99% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3165fc7...4430987. Read the comment docs.

@axunonb axunonb merged commit ca28b30 into axuno:main Oct 21, 2021
@axunonb axunonb deleted the backport-fixes-from-v3 branch October 21, 2021 08:05
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Oct 21, 2021
@axunonb
Squashed commit of the following:
9c03a78 
commit ebb820c
Merge: 365bbd0 ca28b30
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Thu Oct 21 10:06:49 2021 +0200

    Merge branch 'axuno:main' into main

commit ca28b30
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Thu Oct 21 10:05:03 2021 +0200

    Backport fixes from v3 (axuno#213)

    Bumped version to 2.7.1

    Back-ported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 365bbd0
Author: axunonb <nb@axuno.net>
Date:   Thu Oct 21 09:16:12 2021 +0200

    Bumped version to 2.7.1

    Backported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 3165fc7
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Thu Oct 21 08:03:32 2021 +0200

    Updated NuGet secure key

commit 8169585
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Sun Sep 5 23:09:38 2021 +0200

    Update README.md

commit 1e09b6a
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Mon Aug 30 01:52:50 2021 +0200

    Update README.md

commit 8954f3e
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Mon Aug 30 01:51:32 2021 +0200

    Update README.md

commit a16b01c
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Jun 15 00:06:03 2021 +0200

    Update README.md

commit d9462f5
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Jun 15 00:05:17 2021 +0200

    Update README.md
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Nov 2, 2021
@axunonb
Squashed commit of the following:
3c25e7a 
commit a8dec64
Merge: ebb820c c4f0115
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 21:55:35 2021 +0100

    Merge branch 'axuno:main' into main

commit c4f0115
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 21:54:46 2021 +0100

    Delete .github/workflows directory

commit 3283ba9
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 17:05:09 2021 +0100

    Remove demo projects

commit 0ebf3f4
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 16:30:42 2021 +0100

    Corrected path to test project

commit a9a79d1
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 16:22:48 2021 +0100

    Add AltCover to test

commit 608533f
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 16:07:01 2021 +0100

    Update build.yml

commit 3005692
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 15:00:06 2021 +0100

    Update build.yml

commit 4683d59
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 14:23:29 2021 +0100

    Update build.yml

commit d3f9b68
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 14:19:05 2021 +0100

    Update build.yml

commit 4ac19ea
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 14:11:42 2021 +0100

    Update build.yml

commit ef76dba
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 14:08:13 2021 +0100

    Update build.yml

commit e2406b4
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 14:01:07 2021 +0100

    Update build.yml

commit adee45a
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 14:00:40 2021 +0100

    Update build.yml

commit 5464bb9
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Nov 2 13:53:50 2021 +0100

    Create build.yml

commit ebb820c
Merge: 365bbd0 ca28b30
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Thu Oct 21 10:06:49 2021 +0200

    Merge branch 'axuno:main' into main

commit ca28b30
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Thu Oct 21 10:05:03 2021 +0200

    Backport fixes from v3 (axuno#213)

    Bumped version to 2.7.1

    Back-ported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 365bbd0
Author: axunonb <nb@axuno.net>
Date:   Thu Oct 21 09:16:12 2021 +0200

    Bumped version to 2.7.1

    Backported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 3165fc7
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Thu Oct 21 08:03:32 2021 +0200

    Updated NuGet secure key

commit 8169585
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Sun Sep 5 23:09:38 2021 +0200

    Update README.md

commit 1e09b6a
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Mon Aug 30 01:52:50 2021 +0200

    Update README.md

commit 8954f3e
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Mon Aug 30 01:51:32 2021 +0200

    Update README.md

commit a16b01c
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Jun 15 00:06:03 2021 +0200

    Update README.md

commit d9462f5
Author: axunonb <axunonb@users.noreply.github.com>
Date:   Tue Jun 15 00:05:17 2021 +0200

    Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axunonb