Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FormatItem #167

Merged
merged 18 commits into from
May 25, 2021
Merged

Refactor FormatItem #167

merged 18 commits into from
May 25, 2021

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented May 25, 2021

FormatItem abstract class

  • Field baseString renamed to BaseString property
  • Field startIndex renamed to StartIndex property
  • Field endIndex renamed to IndexIndex property
  • Added Lengthproperty (returing EndIndex - StartIndex)

axunonb and others added 17 commits April 17, 2021 10:25
@axunonb
Update issue templates
afd5b77
@axunonb
Inserted a link to merged version/v3 changes
1d22508
@axunonb
Updated README
11c3033
@axunonb
Merge remote-tracking branch 'upstream/main' into version/v3.0
d1779f9
@axunonb
Make parser fully covered with unit tests
cb5559a
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
e327de5
@axunonb
Updated CHANGES.md
cab97df
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
e8d9c93
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
294f810
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
792c391
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
4f45a84
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
e49db1e
@axunonb
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
2c562b5
@axunonb
Updated .editorconfig
2ba8c5f
@axunonb
Refactored FormatItem and subclasses
7abd871
@axunonb
Added comments to FormatItem and Parser
5f60d8b
@axunonb
Update CHANGES.md
8fca681
@codecov
Copy link

codecov bot commented May 25, 2021 •
edited
Loading

Codecov Report

Merging #167 (36a841e) into version/v3.0 (ae266b6) will decrease coverage by 0%.
The diff coverage is 84%.

❗ Current head 36a841e differs from pull request most recent head 821dcd6. Consider uploading reports for the commit 821dcd6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           version/v3.0   #167   +/-   ##
===========================================
- Coverage            95%    94%   -0%     
===========================================
  Files                42     42           
  Lines              1833   1830    -3     
===========================================
- Hits               1733   1724    -9     
- Misses              100    106    +6
Impacted Files Coverage Δ
src/SmartFormat/Core/Parsing/FormatItem.cs 50% <38%> (-31%) ⬇️
...rtFormat/Extensions/PluralLocalizationFormatter.cs 95% <50%> (ø)
src/SmartFormat/Core/Parsing/LiteralText.cs 69% <62%> (-10%) ⬇️
src/SmartFormat/Core/Parsing/Parser.cs 96% <94%> (-<1%) ⬇️
...SmartFormat/Core/Formatting/FormattingException.cs 100% <100%> (ø)
src/SmartFormat/Core/Formatting/FormattingInfo.cs 94% <100%> (ø)
src/SmartFormat/Core/Parsing/Format.cs 84% <100%> (+1%) ⬆️
src/SmartFormat/Core/Parsing/ParsingErrors.cs 100% <100%> (ø)
src/SmartFormat/Core/Parsing/Placeholder.cs 97% <100%> (ø)
src/SmartFormat/Core/Parsing/Selector.cs 100% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae266b6...821dcd6. Read the comment docs.

@axunonb axunonb merged commit cceb400 into axuno:version/v3.0 May 25, 2021
@axunonb axunonb deleted the Refactor-FormatItem branch May 25, 2021 18:30
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Mar 10, 2022
@axunonb
Refactor FormatItem (axuno#167)
6fa430a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axunonb