Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove README link to non-existent upgrade guide #5307

Merged
merged 2 commits into from
Dec 1, 2022
Merged

docs: remove README link to non-existent upgrade guide #5307

merged 2 commits into from
Dec 1, 2022
+0 −1

Conversation

zachlysobey
Copy link
Contributor

@zachlysobey zachlysobey commented Nov 24, 2022 •
edited
Loading

Related Issues

Description

This PR removes a broken UPGRADE_GUIDE.md link from the (1.x) README.

Really, the guide should be added/updated, but I think it may be better to just omit it until the doc is ready.
A broken link is worse than no link.

Alternatives considered

  1. Write an upgrade guide: I don't think I have the context
  2. Create a stub guide: Personally I think this is less good than just not having a link, but perhaps it'd make the eventual future addition of such a guide easier. If that's the preferred option, I can open a PR to do that instead.

@zachlysobey zachlysobey mentioned this pull request Nov 24, 2022
Closed
@jasonsaayman jasonsaayman merged commit 6d367b9 into axios:v1.x Dec 1, 2022
@zachlysobey zachlysobey deleted the patch-1 branch December 5, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachlysobey @jasonsaayman