Fixing Z_BUF_ERROR when no content #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed issues with eslint tests |
|
Thanks this looks good 😊 |
|
@jasonsaayman you can probably close these when this is in; |
|
Thanks will do |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When response headers content-encoding is set but no content exist zlib fails with Z_BUF_ERROR.
Solution is to check if data exist, if it does not we should never try to decompress.
If no data exists, but content-encoding still says it is encoded we simply remove the header not confuse downstream operations.
Fixes:
#3989
#3648
#3055