Fixing ProgressEvent type definitions so that Axios doesn't have to depend on lib dom (Fixes #3219) #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santiago8888
approved these changes
Aug 25, 2020
1 task
sk-
reviewed
Sep 8, 2020
sk-
reviewed
Sep 9, 2020
There was a problem hiding this comment.
Thanks @jan-molak, I think it's much better now.
Let's see what the maintainers think about it.
@jasonsaayman any chance to review this PR?
sk-
approved these changes
Sep 9, 2020
Merged
|
Closed in favor of #3237 (comment). Thanks for your contribution all the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #3219, Axios 0.20.0 introduced an implicit dependency on lib dom, which prevents transpilation of pure Node.js projects using Axios (such as Serenity/JS REST).
Instead of making the dependency semi-explicit, as per the suggestion in #3221, I'd like to propose to avoid the dependency altogether by replacing
ProgeressEventtype with its structural equivalent:This change will allow Axios (and any other project using, for that matter) to avoid having to depend on lib dom while still providing type information better than using
any.