-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking behavior in params serialization in 0.28.0 #6274
Comments
Might be a duplicate of #6262 |
No, it's not fixed. Just tested with 0.28.1. Feel free to test yourself by making a request like in the initial comment and checking brower network inspector for what is being sent. |
@rchl I see, perhaps it is a different issue. v0.28.1 allows you to have a custom |
Would make sense to keep the old behavior to prevent breaking changes unless there is a good reason to deviate. And if there is then it should be clearly marked as a breaking change and there should be good reason for it (standards compliance or similar). |
@butchtm I've tried to replicate the serialization behavior that was implemented in prior versions to 0.28 below
|
I've similarly observed a breaking change that I believe is related and was not included in the CHANGELOG. Specifically, before
When passed to axios.get – like
In 0.28.0, that same request yields the following querystring params (excluding the
This is a seemingly understandable optimization, but is in fact a breaking change for anyone who relies on that functionality to remain as-is. |
it seems the problem has resolved in this issuse,but the lastest version v0.28.1 also has this problem |
Any update of this? Version v0.28.1 does not solve this issue, is there an ETA for this fix? |
Have to say this is very badly handled and like makes really wonder should one even try to use the newer axios versions in the future is this is how the project is maintained. Minor release. Breaking change. No mention about it. Then releases a patch version that has ability to control it, but no mention on officially how to keep the backwards compatible behavior. And then 🦗 🦗 🦗 |
Describe the bug
In 0.28.0 there is a breaking change to params serialization that wasn't mentioned as such in the changelog.
Probably related to c05ad48 and 807918b
If this is an expected change then it should have been noted in the changelog as breaking. Otherwise it should be fixed.
@DigitalBrainJS
To Reproduce
Send a get request with one of the
params
values being an object with key/value properties.Code snippet
Expected behavior
Previously the
p
param would be serialized as such:&p={"a":"z"}
With 0.28.0:
&p[a]=z
Axios Version
0.28.0
Adapter Version
No response
Browser
No response
Browser Version
No response
Node.js Version
No response
OS
No response
Additional Library Versions
No response
Additional context/Screenshots
No response
The text was updated successfully, but these errors were encountered: