Refactor queued projections #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
force-pushed
the
refactor-queued-projections
branch
3 times, most recently
from
5b0da08 to
df020ba
Compare
mtdowling
reviewed
Nov 2, 2021
smithy-build/src/main/java/software/amazon/smithy/build/ProjectionTransformer.java
Outdated
Show resolved
Hide resolved
TransformContext's queued projections were a side effect of transformer execution, and TransformContext instances were not maintained throughout projection execution. In particular, BackwardCompatHelper would create a new instance of TransformContext for its subclasses, but relying on a side effect of transformation was dangerous in any case. This adds a new method to ProjectionTransformer that explicitly models composition of transforms by returning the names of projections to be run subsequently. It is defaulted to an empty list.
adamthom-amzn
force-pushed
the
refactor-queued-projections
branch
from
df020ba to
3803b7f
Compare
mtdowling
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
TransformContext's queued projections were a side effect of transformer
execution, and TransformContext instances were not maintained throughout
projection execution. In particular, BackwardCompatHelper would create a new
instance of TransformContext for its subclasses, but relying on a side effect
of transformation was dangerous in any case.
This adds a new method to ProjectionTransformer that explicitly models
composition of transforms by returning the names of projections to be run
subsequently. It is defaulted to an empty list.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.