Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a model for validation errors #813

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

adamthom-amzn
Copy link
Contributor

Server SDKs need a common, framework-level definition of a validation error
that service authors can opt into.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adamthom-amzn adamthom-amzn marked this pull request as draft May 28, 2021 17:22
@adamthom-amzn adamthom-amzn force-pushed the main branch 2 times, most recently from 5012cb8 to 619bfc9 Compare June 9, 2021 23:22
@adamthom-amzn adamthom-amzn marked this pull request as ready for review June 11, 2021 16:55
@gosar gosar requested a review from JordonPhillips June 11, 2021 17:06
Server SDKs need a common, framework-level definition of a validation error
that service authors can opt into.
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamthom-amzn adamthom-amzn dismissed JordonPhillips’s stale review June 11, 2021 21:39

made the updates, got other reviews

@adamthom-amzn adamthom-amzn merged commit c730b33 into smithy-lang:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants