-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smithy CLI init command #1802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
init
branch
3 times, most recently
from
June 5, 2023 18:07
d858cc0
to
8a35bf2
Compare
mtdowling
reviewed
Jun 5, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some integration tests?
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
init
branch
9 times, most recently
from
June 6, 2023 16:39
00c6c24
to
d467591
Compare
hpmellema
reviewed
Jun 6, 2023
...urces/software/amazon/smithy/cli/projects/smithy-templates/getting-started-example/README.md
Outdated
Show resolved
Hide resolved
...urces/software/amazon/smithy/cli/projects/smithy-templates/getting-started-example/README.md
Outdated
Show resolved
Hide resolved
.../src/it/resources/software/amazon/smithy/cli/projects/smithy-templates/smithy-templates.json
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
hpmellema
approved these changes
Jun 6, 2023
mtdowling
requested changes
Jun 6, 2023
smithy-utils/src/main/java/software/amazon/smithy/utils/IoUtils.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
...ources/software/amazon/smithy/cli/projects/smithy-templates/getting-started-example/Makefile
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Jun 7, 2023
.../src/it/resources/software/amazon/smithy/cli/projects/smithy-templates/smithy-templates.json
Outdated
Show resolved
Hide resolved
.../src/it/resources/software/amazon/smithy/cli/projects/smithy-templates/smithy-templates.json
Show resolved
Hide resolved
.../src/it/resources/software/amazon/smithy/cli/projects/smithy-templates/smithy-templates.json
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Jun 15, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
smithy init -t quickstart-cli
smithy init -t quickstart-cli -o hello-world
smithy init --template quickstart-cli --output hello-world
smithy init -t quickstart-cli -o hello-world --url <custom template repository url>
smithy-templates.json
and template filesTesting:
./gradlew :smithy-cli:runtime
./smithy/smithy-cli/build/image/smithy-cli-darwin-x86_64/bin/smithy init --template quickstart-cli --output hello-world --url ssh://git.amazon.com/pkg/Smithy-Examples
hello-world
directory is created and contains content fromquickstart-cli
templateBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.