Convert to internal trait from tag #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvschneid
approved these changes
Apr 18, 2023
|
We should document this behavior too. I think add javadoc to relevant methods in I also noticed we have |
gosar
approved these changes
Apr 18, 2023
mtdowling
approved these changes
Apr 18, 2023
Added separate PR in #1740. |
gosar
approved these changes
Apr 20, 2023
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Outdated
Show resolved
Hide resolved
hpmellema
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how EnumShapes are converted from strings with the deprecated
@enumtrait by adding the@internaltrait to the resulting Enum shape member when when the source enum value was tagged withinternal.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.