Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return internal enum values #1658

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Do not return internal enum values #1658

merged 1 commit into from
Mar 6, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Mar 6, 2023

This PR updates the enum validation protocol tests to exclude returning enum values that have been marked as internal with the @internal trait or tagged as internal.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner March 6, 2023 19:36
@gosar
Copy link
Contributor

gosar commented Mar 6, 2023

There was some concern on using internal tag as well in this (along with @internal trait), but we side towards using internal tags for this purpose too, as tags are also commonly used to mark shapes for internal use, and we'd rather not have a surprise for such users. If one wanted to use the internal tag for another purpose, they can use a different label.

@srchase srchase merged commit 30201cb into smithy-lang:main Mar 6, 2023
@srchase srchase deleted the enum-validation branch March 6, 2023 21:42
@srchase srchase mentioned this pull request Mar 8, 2023
Merged
@hlbarber hlbarber mentioned this pull request Mar 16, 2023
Open
@david-perez david-perez mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosar gosar gosar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srchase @gosar