Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Comparable interface for TagObject and ExternalDocumentation #1589

Merged
merged 1 commit into from
Jan 25, 2023
Merged

implement Comparable interface for TagObject and ExternalDocumentation #1589

merged 1 commit into from
Jan 25, 2023

Conversation

AndrewFossAWS
Copy link
Contributor

Issue #, if available:
The OpenAPI class sorts TagObjects here but TagObject is not comparable.

Description of changes:
Implement Comparable inteface for TagObject and ExternalDocumentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndrewFossAWS AndrewFossAWS requested a review from a team as a code owner January 23, 2023 23:30
@AndrewFossAWS AndrewFossAWS merged commit 81b3e44 into smithy-lang:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugmanue sugmanue sugmanue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewFossAWS @sugmanue