Add docs for inline io and mixins #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Jan 15, 2022
docs/source/1.0/spec/core/model.rst
Outdated
| operations: [OperationC] | ||
| } | ||
|
|
||
| The ``version`` property of the local shape is kept and the ``rename`` and |
There was a problem hiding this comment.
Might simplify to say "The flattned equivalent of C with no mixins is:", and then remove the redefined operations since the other service shapes aren't defined either.
There was a problem hiding this comment.
remove the redefined operations since the other service shapes aren't defined either
I'm not sure what you mean by this. The operations need to be there because they're still used.
JordonPhillips
force-pushed
the
inline-io-docs
branch
from
31f37f7 to
64c2050
Compare
mtdowling
reviewed
Jan 19, 2022
mtdowling
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for inline io and mixins. This documentation was mostly pulled from the design docs, but was updated in a number of places to better fit with the rest of the smithy docs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.