-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for S3 express one zone bucket and automate creation of files for benchmark #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 11:48 — with
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 23, 2024 15:36 — with
GitHub Actions
Failure
…me it takes to run the benchmark Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
sauraank
force-pushed
the
wf-changes/s3-express-benchmark
branch
from
February 23, 2024 16:10
865966f
to
8f1660f
Compare
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 23, 2024 16:10 — with
GitHub Actions
Inactive
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
sauraank
temporarily deployed
to
PR integration tests
February 26, 2024 10:40 — with
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
February 26, 2024 10:40 — with
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
February 26, 2024 10:40 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 26, 2024 10:40 — with
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
February 26, 2024 10:40 — with
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
February 27, 2024 10:42 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 27, 2024 10:42 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 27, 2024 10:42 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 27, 2024 10:42 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 27, 2024 10:42 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 27, 2024 10:42 — with
GitHub Actions
Inactive
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
February 28, 2024 09:53 — with
GitHub Actions
Failure
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
February 28, 2024 10:07 — with
GitHub Actions
Inactive
arsh
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Andres! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a separate workflow for s3 express one bucket benchmark and running that workflow on separate job. We have got successful result on wf-changes/s3-express-benchmark: https://github.com/awslabs/mountpoint-s3/actions/runs/8007392433
Pages for s3 express benchmark: Throughput, Latency
Also added the step of creation objects required for benchmarking within the scripts, so that if it required to setup benchmarking again for some other case, we dont need the manual setup.
Relevant issues:
Does this change impact existing behavior?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).