Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for S3 express one zone bucket and automate creation of files for benchmark #779

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

sauraank
Copy link
Contributor

@sauraank sauraank commented Feb 23, 2024

Description of change

Added a separate workflow for s3 express one bucket benchmark and running that workflow on separate job. We have got successful result on wf-changes/s3-express-benchmark: https://github.com/awslabs/mountpoint-s3/actions/runs/8007392433
Pages for s3 express benchmark: Throughput, Latency

Also added the step of creation objects required for benchmarking within the scripts, so that if it required to setup benchmarking again for some other case, we dont need the manual setup.

Relevant issues:

Does this change impact existing behavior?


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 11:48 — with GitHub Actions Inactive
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
@sauraank sauraank had a problem deploying to PR integration tests February 23, 2024 15:36 — with GitHub Actions Failure
…me it takes to run the benchmark

Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
@sauraank sauraank force-pushed the wf-changes/s3-express-benchmark branch from 865966f to 8f1660f Compare February 23, 2024 16:10
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 23, 2024 16:10 — with GitHub Actions Inactive
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
@sauraank sauraank temporarily deployed to PR integration tests February 26, 2024 10:40 — with GitHub Actions Inactive
@sauraank sauraank had a problem deploying to PR integration tests February 26, 2024 10:40 — with GitHub Actions Failure
@sauraank sauraank temporarily deployed to PR integration tests February 26, 2024 10:40 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 26, 2024 10:40 — with GitHub Actions Inactive
@sauraank sauraank had a problem deploying to PR integration tests February 26, 2024 10:40 — with GitHub Actions Failure
@sauraank sauraank temporarily deployed to PR integration tests February 27, 2024 10:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 27, 2024 10:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 27, 2024 10:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 27, 2024 10:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 27, 2024 10:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 27, 2024 10:42 — with GitHub Actions Inactive
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
Signed-off-by: Ankit Saurabh <sauraank@amazon.co.uk>
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 28, 2024 10:07 — with GitHub Actions Inactive
Copy link
Contributor

@arsh arsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sauraank
Copy link
Contributor Author

Thanks Andres!

@sauraank sauraank added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit f090603 Feb 28, 2024
35 checks passed
@sauraank sauraank deleted the wf-changes/s3-express-benchmark branch February 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants