Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(take 2) Detect when AVX is disabled via OSXSAVE #1184

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Jan 24, 2025

Issue:
There were some bugs in the previous PR: #1182

Description of changes:

  • Fix bug where high and low bits of XGETBV were reversed
  • Add back AVX2 feature detection (accidentally omitted from previous PR)
  • VPCLMULQDQ also depends on AVX being usable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm changed the title Detect when AVX is disabled via OSXSAVE (take 2) (take 2) Detect when AVX is disabled via OSXSAVE Jan 24, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (dac5ad6) to head (0c09aa7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   82.97%   84.27%   +1.29%     
==========================================
  Files          57       57              
  Lines        5972     5976       +4     
==========================================
+ Hits         4955     5036      +81     
+ Misses       1017      940      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graebm graebm merged commit 34013d5 into main Jan 24, 2025
56 checks passed
@graebm graebm deleted the bugfix-avx-xsave-2 branch January 24, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants