Fixup IPv6 validation logic #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
- Coverage 83.63% 82.97% -0.67%
==========================================
Files 57 57
Lines 5953 5973 +20
==========================================
- Hits 4979 4956 -23
- Misses 974 1017 +43 ☔ View full report in Codecov by Sentry. |
sbSteveK
reviewed
Jan 23, 2025
| @@ -28,4 +28,4 @@ jobs: | |||
| run: | | |||
| python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')" | |||
| chmod a+x builder | |||
| ./builder build -p ${{ env.PACKAGE_NAME }} --compiler=gcc-9 --coverage --coverage-exclude=source/external/ | |||
| ./builder build -p ${{ env.PACKAGE_NAME }} --compiler=gcc --coverage --coverage-exclude=source/external/ | |||
There was a problem hiding this comment.
Any particular reason for --compiler=gcc-9 to --compiler=gcc ?
There was a problem hiding this comment.
we dont care about compiler here as much, we just want the default on the system.
the reason it was gcc-9 before was to match it to gcov version on the os image. but once we updated image, gcov got updated and everything broke.
i dont want to update gcc version on every image update, so lets just use default gcc and gcov already on the system
sbSteveK
approved these changes
Jan 23, 2025
graebm
reviewed
Jan 23, 2025
TingDaoK
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, and/or reason for changes (REQUIRED):
is ipv6 helper does not always return correct results for zero expansion cases.
Description of changes:
rewrote the logic to be hopefully simpler to follow and less error prone.
and a whole bunch of test cases
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.