Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: awslabs/aws-c-common
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.10.6
Choose a base ref
...
head repository: awslabs/aws-c-common
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.10.7
Choose a head ref
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on Jan 2, 2025

  1. Configuration menu
    Copy the full SHA
    c5a0812 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2025

  1. Configuration menu
    Copy the full SHA
    0c79778 View commit details
    Browse the repository at this point in the history
  2. Detect when AVX is disabled via OSXSAVE (#1182)

    **Issue #:**
    internal V1647663988
    
    [SEV-SNP enabled EC2 instances](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/sev-snp.html) crash when using AWS CLI to upload with checksum algorithm CRC64NVME. [AWS CLI v2](https://github.com/aws/aws-cli/tree/v2) uses aws-c-common under the hood to do CRC64NVME.
    
    **Investigation:**
    aws-c-common has checks for AVX support, using [CPUID](https://en.wikipedia.org/wiki/CPUID). But apparently, just because CPUID reports that it can do AVX, doesn't necessarily mean it's enabled by the OS. On SEV-SNP enabled instances, AVX is not allowed.
    
    GCC had the same bug until 7.4: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85100
    
    Stackoverflow question: https://stackoverflow.com/questions/72522885/are-the-xgetbv-and-cpuid-checks-sufficient-to-guarantee-avx2-support
    
    **Description of changes:**
    * Do further checks before deciding that AVX can be used.
    * Move all Intel feature detection into 1 function.
       * This is simpler, it's how we're doing feature detection on some other architectures.
       * Add checks to find the max value that CPUID accepts. We weren't doing this before.
    graebm authored Jan 23, 2025
    Configuration menu
    Copy the full SHA
    f6622ac View commit details
    Browse the repository at this point in the history
Loading