Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: awslabs/aws-c-common
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.10.3
Choose a base ref
...
head repository: awslabs/aws-c-common
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.10.4
Choose a head ref
  • 5 commits
  • 5 files changed
  • 6 contributors

Commits on Nov 25, 2024

  1. Doc fix for cbor (#1171)

    TingDaoK authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    45230f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    252e8c2 View commit details
    Browse the repository at this point in the history
  2. Forward CMake variables to prebuilding dependencies (#1161)

    Co-authored-by: Igor Abdrakhimov <igorabd@amazon.com>
    Co-authored-by: Michael Graeb <graebm@amazon.com>
    3 people authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4f3c2ee View commit details
    Browse the repository at this point in the history
  3. Update CBMC proof tooling to latest releases (#1164)

    Co-authored-by: Michael Graeb <graebm@amazon.com>
    tautschnig and graebm authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    da9e1c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Fix test that made no sense (#1172)

    **Issue**
    A recent PR #1170 (comment) fixed an indexing-math bug in this test. When I took a closer look at this test, I noticed it was broken ... and didn't make much sense
    
    **Research:**
    This hash table test was added with the original hash table PR #17.
    
    That branch had 2 different authors, which seems to have led to the brokenness
    - Original [commit](c2a7f08) with this test
    - In this [commit](ab4e987), author B accidentally replaces floating-point-rand with integer-rand, breaking randomness so this test doesn't actually test anything anymore
    - In this [commit](fe71f05), Author A removes some `entries[i -1]` checks that don't really make sense because `entries` isn't sorted
    - In this [commit](a36d2dd), Author B brings the checks back. My guess is there was a merge conflict and they just accepted their own side
    
    **Description of changes**
    - Fix randomness
    - Add comments about what this test is doing
    - Fix the checks, using the `sorted_entries` array instead of the unsorted `entries` array
    graebm authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    be8ed87 View commit details
    Browse the repository at this point in the history
Loading