Add integrity check after write #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
HieronymusLex
requested changes
Mar 31, 2020
…get into integrity
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
…get into integrity
ctd
reviewed
Mar 31, 2020
Co-Authored-By: Chris Deigan <ctd@users.noreply.github.com>
Co-Authored-By: Chris Deigan <ctd@users.noreply.github.com>
ctd
reviewed
Apr 1, 2020
Co-Authored-By: Chris Deigan <ctd@users.noreply.github.com>
Co-Authored-By: Chris Deigan <ctd@users.noreply.github.com>
ctd
approved these changes
Apr 1, 2020
HieronymusLex
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the counter now has a new class of errors, I updated the docs.
I also found there is no place where we actually describe all the steps involved during the deletion (open file, check integrity, put acls, etc). Should we do that in the ARCHITECTURE part under the Forget phase (perhaps later in another PR after we'll have the object version deletion in place).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.