Queue size batching #146
Merged
Queue size batching #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get into queue-size-batching
HieronymusLex
requested changes
Apr 29, 2020
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
Co-Authored-By: Nick Lee <42975160+HieronymusLex@users.noreply.github.com>
HieronymusLex
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the work to ensure a job only processes the items that are able to fit a single Document in DDB (which can't be larger than 400KB).
According to my tests, having this limit is also pretty useful to ensure we are within limits in terms of Athena Query size too.
Turns out you can't just calculate the size of JSON because Dynamo has its own way to calculate the size. Inspired by the docs and this Java implementation I created a simplified version for our python processor that should do the job. I did plenty of manual testing with 10K+ items in the queue and this approach seems quite solid.
To add extra safety, I decided to set the limit to 375KB in order to allow some extra budget for future additions to the Job Document.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.