Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Bug in writeme snippet link order #6850

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Tools: Bug in writeme snippet link order #6850

merged 1 commit into from
Sep 16, 2024

Conversation

DavidSouther
Copy link
Contributor

This pull request sorts snippet tags before finding a preferred snippet tag for README links.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther DavidSouther self-assigned this Sep 12, 2024
@github-actions github-actions bot added C++ This issue relates to the AWS SDK for C++ DotNet-v3 This issue relates to the AWS SDK for .NET V3 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Tools This issue relates to a custom tooling to streamline development tasks labels Sep 12, 2024
Laren-AWS
Laren-AWS requested changes Sep 12, 2024
View reviewed changes
.tools/readmes/scanner.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added Go-v2 This issue relates to the AWS SDK for Go V2 Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) Swift This issue relates to the AWS SDK for Swift CLI Relates to the AWS CLI labels Sep 13, 2024
@DavidSouther DavidSouther force-pushed the bug/writeme/snippet_link_order branch from 127888b to d18d5ef Compare September 13, 2024 02:15
@DavidSouther DavidSouther added the On Call Review needed This work needs an on-call review label Sep 14, 2024
@DavidSouther DavidSouther removed the request for review from ford-at-aws September 14, 2024 21:15
@DavidSouther DavidSouther force-pushed the bug/writeme/snippet_link_order branch from d18d5ef to bccf8c2 Compare September 16, 2024 11:18
@DavidSouther DavidSouther added On Call Review complete On call review complete Bug An update to fix incorrect code or typos. and removed On Call Review needed This work needs an on-call review labels Sep 16, 2024
@DavidSouther DavidSouther merged commit 054d2fb into awsdocs:main Sep 16, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlhagerm rlhagerm rlhagerm approved these changes

@Laren-AWS Laren-AWS Laren-AWS approved these changes

Assignees

@DavidSouther DavidSouther

Labels
Bug An update to fix incorrect code or typos. C++ This issue relates to the AWS SDK for C++ CLI Relates to the AWS CLI DotNet-v3 This issue relates to the AWS SDK for .NET V3 Go-v2 This issue relates to the AWS SDK for Go V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) Swift This issue relates to the AWS SDK for Swift Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidSouther @Laren-AWS @rlhagerm