add git secrets ci ros1 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by aws-robotics/aws-robomaker-github-actions#17. Before merging, requires version bump (to 2.3.4) for all aws-robomaker-gh-actions after is merged. |
mm318
reviewed
Oct 9, 2020
|
The comments in #94 also apply here. |
mm318
reviewed
Oct 16, 2020
.github/workflows/ros1.yml
Outdated
| @@ -41,17 +41,19 @@ jobs: | |||
| run: | | |||
| # TODO(ros-tooling/setup-ros-docker#7): calling chown is necessary for now | |||
| sudo chown -R rosbuild:rosbuild "$HOME" . | |||
| - name: Scan using git-secrets | |||
| uses: aws-robotics/aws-robomaker-github-actions/git-secrets-scan-action@2.4.0 | |||
There was a problem hiding this comment.
You had a concern that doing --scan-history would take a long time, right?
Anyway, I think we should move the scan to a separate workflow YAML file, so that the scanning can take place in parallel with building and bundling.
There was a problem hiding this comment.
Yes I did.. but I tested --scan-history on some public repos with signicantly larger commit history and the time doesn't seem to exceed more than a minute at the most. I feel that should be considerably lesser than what build and bundle takes.
Bump to 2.4.1
Bump to 2.4.1
mm318
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding git secrets scan action to ROS1 workflows
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.