Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow empty string as resourceTag entry #354

Merged
merged 1 commit into from
Jul 14, 2022
Merged

allow empty string as resourceTag entry #354

merged 1 commit into from
Jul 14, 2022

Conversation

vijtrip2
Copy link
Contributor

Description of changes:

  • allow empty string inside resourceTags entry so that users can override the default ACK tag behavior using --set resourceTags={} param during helm installation
  • tested locally that this change allows removing the default ACK tags behavior during helm installation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Jul 14, 2022

@vijtrip2: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
dynamodb-controller-test f832e13 link /test dynamodb-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vijtrip2
Copy link
Contributor Author

/test dynamodb-controller-test

@RedbackThomson
Copy link
Contributor

Yes please
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vijtrip2 vijtrip2 merged commit cb4bca8 into aws-controllers-k8s:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes Awaiting requested review from jaypipes

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@RedbackThomson RedbackThomson

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijtrip2 @ack-bot @RedbackThomson