Fix s3bucket option for stackset deploy #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericzbeard
approved these changes
Nov 19, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 21, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aws-cloudformation/rain](https://github.com/aws-cloudformation/rain) | minor | `v1.19.0` -> `v1.20.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aws-cloudformation/rain (aws-cloudformation/rain)</summary> ### [`v1.20.2`](https://github.com/aws-cloudformation/rain/releases/tag/v1.20.2) [Compare Source](aws-cloudformation/rain@v1.20.1...v1.20.2) This release adds unit tests to make sure the build command will work for all types. #### What's Changed - Version 1.20.2 by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#619 **Full Changelog**: aws-cloudformation/rain@v1.20.1...v1.20.2 ### [`v1.20.1`](https://github.com/aws-cloudformation/rain/releases/tag/v1.20.1) [Compare Source](aws-cloudformation/rain@v1.20.0...v1.20.1) #### What's Changed - Fixing incorrect schema by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#618 **Full Changelog**: aws-cloudformation/rain@v1.20.0...v1.20.1 ### [`v1.20.0`](https://github.com/aws-cloudformation/rain/releases/tag/v1.20.0) [Compare Source](aws-cloudformation/rain@v1.19.0...v1.20.0) #### What's Changed - Remove confirmation prompt for deploy --no-exec by [@​clncy](https://github.com/clncy) in aws-cloudformation/rain#587 - Module packages by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#582 - Fix s3bucket option for stackset deploy by [@​Scribbd](https://github.com/Scribbd) in aws-cloudformation/rain#593 - Schema updates for version bump by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#613 #### New Contributors - [@​clncy](https://github.com/clncy) made their first contribution in aws-cloudformation/rain#587 - [@​Scribbd](https://github.com/Scribbd) made their first contribution in aws-cloudformation/rain#593 **Full Changelog**: aws-cloudformation/rain@v1.19.0...v1.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Ny4wIiwidXBkYXRlZEluVmVyIjoiMzkuNzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #528
Description of changes:
While using the feature requested in the mentioned ticket, rain didn't accept the
--s3-bucketonrain stackset deploy. It only worked forrain stacksetthe subcommand 'root'.After investigating the original change and comparing how the s3 commands are made available in
rain cc,rain deployandrmI offer this MR that allows the use of the s3-commands withrain stackset deploy.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.