Fix handling short notation form for !GetAtt #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray form 2. Included type information in error message 3. Change parse-tree to pretty-print for JSON
joshfried-aws
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Hi @dchakrav-github the code looks good, would it be possible to add a couple of unit tests to handle this use case?
|
Hi @dchakrav-github just to let you know the GetAtt bug was fixed as part of #325. |
|
Going to close this PR since the main issue of this PR was already addressed, and i have now updated a new pr with the rest of the fixes in this. Thanks @dchakrav-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NEW bug found when testing
Description of changes:
Fn::GetAtt, like!GetAtt MyKey.Arn, the argument was used directly as a string. This change coverts it correctly into the long form for Fn::GetAtt.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license