Added link to docs for local development to CONTRIBUTING #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haverchuck
approved these changes
Oct 4, 2019
|
@dabit3 - We've converted the react package to tsx, so the change you've made to the ForgotPassword component is showing up as a conflict (and it's trying to re-add the jsx file to the repo). Would you mind pulling down latest and making the autocomplete change to the tsx file? |
Codecov Report
@@ Coverage Diff @@
## master #3990 +/- ##
=======================================
Coverage 70.68% 70.68%
=======================================
Files 168 168
Lines 9728 9728
Branches 2020 1971 -49
=======================================
Hits 6876 6876
Misses 2493 2493
Partials 359 359Continue to review full report at Codecov.
|
sammartinez
reviewed
Oct 7, 2019
There was a problem hiding this comment.
@haverchuck @dabit3 Can we fix the typo? I see To run Amplify Amplify JS locally seems strange
|
@sammartinez just submitted an update, thanks! |
sammartinez
pushed a commit
that referenced
this pull request
Oct 9, 2019
* disabled autocomplete when resetting password for new password field * added local development resources to contributing * fixed typo in CONTRIBUTING doc, #3990
Amplifiyer
pushed a commit
to Amplifiyer/amplify-js
that referenced
this pull request
Oct 14, 2019
…#3990) * disabled autocomplete when resetting password for new password field * added local development resources to contributing
Amplifiyer
pushed a commit
to Amplifiyer/amplify-js
that referenced
this pull request
Oct 14, 2019
* disabled autocomplete when resetting password for new password field * added local development resources to contributing * fixed typo in CONTRIBUTING doc, aws-amplify#3990
Amplifiyer
added a commit
that referenced
this pull request
Oct 17, 2019
* Build ES6 Modules along with CJS Modules * Upgrade Typescript to 3.5 * Upgrade Webpack to 4 * Upgrade Jest to 24 [Delivers #168385455] * Removing unused variable from build scripts * Fix signout component being undefined * Fix PR comments * Apply Prettier formatting * Merge branch 'master' of github.com:aws-amplify/amplify-js into modularization-merge * Fix tests that were failing after merge from master * Revert docs and other directories impacted by prettier * Update repository and homepage urls for all packages * Add diagnostic information to build script in event of failures * Revert formatter command as library now used Prettier with pre-commit hook * Adding unit test for pubsub desconnection issue * Fixing websocket disconnect issue on MqttProvider * Update stale.yml * fix: lerna linking for unstable and beta * fix(amazon-cognito-identity-js): linting config (#4097) * partially resolves linting issues in cognito sdk * removes no-cap lint change * using prettier to extend eslint in cognito sdk * removing newline * using airbnb lint config as well as prettier * Fix failing pubsub tests because of jest upgrade * Fix issue SignOut component being undefined * Apply suggestions from code review Co-Authored-By: Manuel Iglesias <manuel.iglesias@gmail.com> * Made mock window worker in angular tests more explicit * Fix failing pubsub tests because of jest upgrade * fix(@aws-amplify/core): removed unused variables (#3926) * Added link to docs for local development to CONTRIBUTING (#3990) * disabled autocomplete when resetting password for new password field * added local development resources to contributing * Fixed typo (#4156) * disabled autocomplete when resetting password for new password field * added local development resources to contributing * fixed typo in CONTRIBUTING doc, #3990 * fix(@aws-amplify/api) Adding x-amz-user-agent for AppSync calls * Adding x-amz-user-agent for appsync calls * Fixing unit test * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.1.0 - @aws-amplify/ui@1.1.0 - @aws-amplify/analytics@1.3.0 - @aws-amplify/api@1.2.0 - @aws-amplify/auth@1.4.0 - aws-amplify-angular@3.1.0 - aws-amplify-react-native@2.2.0 - aws-amplify-react@2.5.0 - aws-amplify-vue@0.3.0 - aws-amplify@1.2.0 - @aws-amplify/cache@1.1.0 - @aws-amplify/core@1.2.0 - @aws-amplify/interactions@1.1.0 - @aws-amplify/predictions@1.1.0 - @aws-amplify/pubsub@1.2.0 - @aws-amplify/pushnotification@1.1.0 - @aws-amplify/storage@1.2.0 - @aws-amplify/xr@0.2.0 * Publish - amazon-cognito-identity-js@3.1.1 - @aws-amplify/ui@1.1.1 - @aws-amplify/analytics@1.3.1 - @aws-amplify/api@1.2.1 - @aws-amplify/auth@1.4.1 - aws-amplify-angular@3.1.1 - aws-amplify-react-native@2.2.1 - aws-amplify-react@2.5.1 - aws-amplify-vue@0.3.1 - aws-amplify@1.2.1 - @aws-amplify/cache@1.1.1 - @aws-amplify/core@1.2.1 - @aws-amplify/interactions@1.1.1 - @aws-amplify/predictions@1.1.1 - @aws-amplify/pubsub@1.2.1 - @aws-amplify/pushnotification@1.1.1 - @aws-amplify/storage@1.2.1 - @aws-amplify/xr@0.2.1 * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.1.2 - @aws-amplify/ui@1.1.2 - @aws-amplify/analytics@1.3.2 - @aws-amplify/api@1.2.2 - @aws-amplify/auth@1.4.2 - aws-amplify-angular@3.1.2 - aws-amplify-react-native@2.2.2 - aws-amplify-react@2.5.2 - aws-amplify-vue@0.3.2 - aws-amplify@1.2.2 - @aws-amplify/cache@1.1.2 - @aws-amplify/core@1.2.2 - @aws-amplify/interactions@1.1.2 - @aws-amplify/predictions@1.1.2 - @aws-amplify/pubsub@1.2.2 - @aws-amplify/pushnotification@1.1.2 - @aws-amplify/storage@1.2.2 - @aws-amplify/xr@0.2.2 * fix(#4001) (#4131) * fix picker parent style (#4135) * Reduce threads to 1 while running jest tests as Circle CI constantly running out of memory * Remove unnecessary async/awaits in pubsub tests * Add Credentials mock explicitly on two tests that are failing only in circle ci * Move spyon in beforeEach
computationalcore
pushed a commit
to computationalcore/amplify-js
that referenced
this pull request
Feb 4, 2020
* Build ES6 Modules along with CJS Modules * Upgrade Typescript to 3.5 * Upgrade Webpack to 4 * Upgrade Jest to 24 [Delivers #168385455] * Removing unused variable from build scripts * Fix signout component being undefined * Fix PR comments * Apply Prettier formatting * Merge branch 'master' of github.com:aws-amplify/amplify-js into modularization-merge * Fix tests that were failing after merge from master * Revert docs and other directories impacted by prettier * Update repository and homepage urls for all packages * Add diagnostic information to build script in event of failures * Revert formatter command as library now used Prettier with pre-commit hook * Adding unit test for pubsub desconnection issue * Fixing websocket disconnect issue on MqttProvider * Update stale.yml * fix: lerna linking for unstable and beta * fix(amazon-cognito-identity-js): linting config (aws-amplify#4097) * partially resolves linting issues in cognito sdk * removes no-cap lint change * using prettier to extend eslint in cognito sdk * removing newline * using airbnb lint config as well as prettier * Fix failing pubsub tests because of jest upgrade * Fix issue SignOut component being undefined * Apply suggestions from code review Co-Authored-By: Manuel Iglesias <manuel.iglesias@gmail.com> * Made mock window worker in angular tests more explicit * Fix failing pubsub tests because of jest upgrade * fix(@aws-amplify/core): removed unused variables (aws-amplify#3926) * Added link to docs for local development to CONTRIBUTING (aws-amplify#3990) * disabled autocomplete when resetting password for new password field * added local development resources to contributing * Fixed typo (aws-amplify#4156) * disabled autocomplete when resetting password for new password field * added local development resources to contributing * fixed typo in CONTRIBUTING doc, aws-amplify#3990 * fix(@aws-amplify/api) Adding x-amz-user-agent for AppSync calls * Adding x-amz-user-agent for appsync calls * Fixing unit test * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.1.0 - @aws-amplify/ui@1.1.0 - @aws-amplify/analytics@1.3.0 - @aws-amplify/api@1.2.0 - @aws-amplify/auth@1.4.0 - aws-amplify-angular@3.1.0 - aws-amplify-react-native@2.2.0 - aws-amplify-react@2.5.0 - aws-amplify-vue@0.3.0 - aws-amplify@1.2.0 - @aws-amplify/cache@1.1.0 - @aws-amplify/core@1.2.0 - @aws-amplify/interactions@1.1.0 - @aws-amplify/predictions@1.1.0 - @aws-amplify/pubsub@1.2.0 - @aws-amplify/pushnotification@1.1.0 - @aws-amplify/storage@1.2.0 - @aws-amplify/xr@0.2.0 * Publish - amazon-cognito-identity-js@3.1.1 - @aws-amplify/ui@1.1.1 - @aws-amplify/analytics@1.3.1 - @aws-amplify/api@1.2.1 - @aws-amplify/auth@1.4.1 - aws-amplify-angular@3.1.1 - aws-amplify-react-native@2.2.1 - aws-amplify-react@2.5.1 - aws-amplify-vue@0.3.1 - aws-amplify@1.2.1 - @aws-amplify/cache@1.1.1 - @aws-amplify/core@1.2.1 - @aws-amplify/interactions@1.1.1 - @aws-amplify/predictions@1.1.1 - @aws-amplify/pubsub@1.2.1 - @aws-amplify/pushnotification@1.1.1 - @aws-amplify/storage@1.2.1 - @aws-amplify/xr@0.2.1 * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.1.2 - @aws-amplify/ui@1.1.2 - @aws-amplify/analytics@1.3.2 - @aws-amplify/api@1.2.2 - @aws-amplify/auth@1.4.2 - aws-amplify-angular@3.1.2 - aws-amplify-react-native@2.2.2 - aws-amplify-react@2.5.2 - aws-amplify-vue@0.3.2 - aws-amplify@1.2.2 - @aws-amplify/cache@1.1.2 - @aws-amplify/core@1.2.2 - @aws-amplify/interactions@1.1.2 - @aws-amplify/predictions@1.1.2 - @aws-amplify/pubsub@1.2.2 - @aws-amplify/pushnotification@1.1.2 - @aws-amplify/storage@1.2.2 - @aws-amplify/xr@0.2.2 * fix(aws-amplify#4001) (aws-amplify#4131) * fix picker parent style (aws-amplify#4135) * Reduce threads to 1 while running jest tests as Circle CI constantly running out of memory * Remove unnecessary async/awaits in pubsub tests * Add Credentials mock explicitly on two tests that are failing only in circle ci * Move spyon in beforeEach
rasfra
pushed a commit
to epidemicsound/amplify-js
that referenced
this pull request
Mar 11, 2020
* Build ES6 Modules along with CJS Modules * Upgrade Typescript to 3.5 * Upgrade Webpack to 4 * Upgrade Jest to 24 [Delivers #168385455] * Removing unused variable from build scripts * Fix signout component being undefined * Fix PR comments * Apply Prettier formatting * Merge branch 'master' of github.com:aws-amplify/amplify-js into modularization-merge * Fix tests that were failing after merge from master * Revert docs and other directories impacted by prettier * Update repository and homepage urls for all packages * Add diagnostic information to build script in event of failures * Revert formatter command as library now used Prettier with pre-commit hook * Adding unit test for pubsub desconnection issue * Fixing websocket disconnect issue on MqttProvider * Update stale.yml * fix: lerna linking for unstable and beta * fix(amazon-cognito-identity-js): linting config (aws-amplify#4097) * partially resolves linting issues in cognito sdk * removes no-cap lint change * using prettier to extend eslint in cognito sdk * removing newline * using airbnb lint config as well as prettier * Fix failing pubsub tests because of jest upgrade * Fix issue SignOut component being undefined * Apply suggestions from code review Co-Authored-By: Manuel Iglesias <manuel.iglesias@gmail.com> * Made mock window worker in angular tests more explicit * Fix failing pubsub tests because of jest upgrade * fix(@aws-amplify/core): removed unused variables (aws-amplify#3926) * Added link to docs for local development to CONTRIBUTING (aws-amplify#3990) * disabled autocomplete when resetting password for new password field * added local development resources to contributing * Fixed typo (aws-amplify#4156) * disabled autocomplete when resetting password for new password field * added local development resources to contributing * fixed typo in CONTRIBUTING doc, aws-amplify#3990 * fix(@aws-amplify/api) Adding x-amz-user-agent for AppSync calls * Adding x-amz-user-agent for appsync calls * Fixing unit test * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.1.0 - @aws-amplify/ui@1.1.0 - @aws-amplify/analytics@1.3.0 - @aws-amplify/api@1.2.0 - @aws-amplify/auth@1.4.0 - aws-amplify-angular@3.1.0 - aws-amplify-react-native@2.2.0 - aws-amplify-react@2.5.0 - aws-amplify-vue@0.3.0 - aws-amplify@1.2.0 - @aws-amplify/cache@1.1.0 - @aws-amplify/core@1.2.0 - @aws-amplify/interactions@1.1.0 - @aws-amplify/predictions@1.1.0 - @aws-amplify/pubsub@1.2.0 - @aws-amplify/pushnotification@1.1.0 - @aws-amplify/storage@1.2.0 - @aws-amplify/xr@0.2.0 * Publish - amazon-cognito-identity-js@3.1.1 - @aws-amplify/ui@1.1.1 - @aws-amplify/analytics@1.3.1 - @aws-amplify/api@1.2.1 - @aws-amplify/auth@1.4.1 - aws-amplify-angular@3.1.1 - aws-amplify-react-native@2.2.1 - aws-amplify-react@2.5.1 - aws-amplify-vue@0.3.1 - aws-amplify@1.2.1 - @aws-amplify/cache@1.1.1 - @aws-amplify/core@1.2.1 - @aws-amplify/interactions@1.1.1 - @aws-amplify/predictions@1.1.1 - @aws-amplify/pubsub@1.2.1 - @aws-amplify/pushnotification@1.1.1 - @aws-amplify/storage@1.2.1 - @aws-amplify/xr@0.2.1 * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.1.2 - @aws-amplify/ui@1.1.2 - @aws-amplify/analytics@1.3.2 - @aws-amplify/api@1.2.2 - @aws-amplify/auth@1.4.2 - aws-amplify-angular@3.1.2 - aws-amplify-react-native@2.2.2 - aws-amplify-react@2.5.2 - aws-amplify-vue@0.3.2 - aws-amplify@1.2.2 - @aws-amplify/cache@1.1.2 - @aws-amplify/core@1.2.2 - @aws-amplify/interactions@1.1.2 - @aws-amplify/predictions@1.1.2 - @aws-amplify/pubsub@1.2.2 - @aws-amplify/pushnotification@1.1.2 - @aws-amplify/storage@1.2.2 - @aws-amplify/xr@0.2.2 * fix(aws-amplify#4001) (aws-amplify#4131) * fix picker parent style (aws-amplify#4135) * Reduce threads to 1 while running jest tests as Circle CI constantly running out of memory * Remove unnecessary async/awaits in pubsub tests * Add Credentials mock explicitly on two tests that are failing only in circle ci * Move spyon in beforeEach
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.