Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files needed for OSGi and Eclipse #4

Merged
merged 1 commit into from
Dec 5, 2011
Merged

Files needed for OSGi and Eclipse #4

merged 1 commit into from
Dec 5, 2011

Conversation

thallgren
Copy link
Contributor

This commit contains the files needed for:

a) Use the aws-sdk-for-java as an OSGi bundle
b) Work with the source using the Eclipse IDE

Please add them, it makes the life a lot easier for the Eclipse community when they are present and they don't have any negative impact in other IDE's or runtime environments.

@electrum
Copy link

Why are the Eclipse project files needed for a Maven project? Install the m2e plugin and Eclipse will generate the project from the POM.

The OSGi manifest should be generated as part of the Maven build (for example, using the maven-bundle-plugin) rather than being a static file in the source tree.

@thallgren
Copy link
Contributor Author

Maven can handle both approaches, i.e. a static OSGi manifest or a generated one. The Eclipse project files provided with this commit will not interfere with that. There are many projects at Eclipse.org that provides both Maven and Eclipse artifacts. This means that while you certainly may use m2e, it's not a requirement. The Eclipse IDE is fully capable of producing the bundle without it.

@fulghum
Copy link
Contributor

fulghum commented Nov 22, 2011

Changes for .project and .classpath look good. I like electrum's comment about generating the OSGi manifest file so that it doesn't need to be updated by hand. We can take a look at our build and deploy process on this side to see how we can fit that in. I'd prefer not to provide any JDT preferences if possible. Are there some specific compiler settings in there that were fixing some problems?

@thallgren
Copy link
Contributor Author

The problem with generating the OSGi is that you then also impose a requirement for a specific build system. Using the manifest as the pristine source for dependencies (somehting that Maven is capable of today), removes this requirement. The IDE is then sufficient to build the bundle. That means that other build tools that depend on the functionality provided by the IDE can build it too.

The JDT preferences were added to remove compiler warnings. The package contains a lot of unused imports and some raw types that should be parameterized.

fulghum added a commit that referenced this pull request Dec 5, 2011
Project metadata for OSGi and Eclipse
@fulghum fulghum merged commit 14ca3e6 into aws:master Dec 5, 2011
@fulghum
Copy link
Contributor

fulghum commented Dec 5, 2011

Thanks for the contribution Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants