Support presigned PUT requests with content-type #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest Made generatePresignedUrl in AmazonS3Client pick up that content-type when generating the signature method argument name in javadoc corrected to match the actual argument
|
Hey Sebastian, this change looks good, but can you hold off on the StorageGateway renaming? We need to fix that over here on our end. |
|
closed and added new pull request that solely contains the content-type change https://github.com/amazonwebservices/aws-sdk-for-java/pull/22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jason,
I stumbled across the fact that I was unable to create presigned URLs for PUTs with content-type. See this [stackoverflow http://stackoverflow.com/questions/10100193/put-file-to-s3-with-presigned-url] for details.
The first commit just corrects some filenames: camelcase of the filenames differed from the camelcase of the classes (I did this basically to make my IDE happy)
The second commit is the actual fix. It adds a content-type property to the GeneratePresignedUrlRequest and makes AmazonS3Client pick up the property for signature creation.
I'd really appreciate to see that included in the next release.
Best Regards,
Sebastian