Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 copy update the bytesTransferred on Copy completion #1510

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

stevorobs3
Copy link

This is to fix issue #1502 by improving the documentation and updating the bytesTransferred on Copy completion

@millems
Copy link
Contributor

millems commented Mar 15, 2018

Thanks for your contribution! Can you confirm you're fine submitting it under the Apache License, Version 2.0 (http://aws.amazon.com/apache2.0)?

@stevorobs3
Copy link
Author

Yes I'm more than happy to submit under that license.

As a side note: I wonder if there is a way to automate that question using travis?

@millems
Copy link
Contributor

millems commented Mar 16, 2018

Great question to ask! In our V2 repository, we automate that question with a PR template. We haven't back-filled that to the V1 repository quite yet.

@millems millems merged commit 41f324f into aws:master Mar 16, 2018
@stevorobs3 stevorobs3 deleted the s3_copy branch April 3, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants