Properties Auth Scheme Path Fix #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2023 13:06
isaiahvita
reviewed
Jul 7, 2023
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsEndpointAuthSchemeGenerator.java
Outdated
Show resolved
Hide resolved
isaiahvita
approved these changes
Jul 7, 2023
added 2 commits
July 7, 2023 13:36
lucix-aws
approved these changes
Jul 7, 2023
isaiahvita
pushed a commit
to isaiahvita/aws-sdk-go-v2
that referenced
this pull request
Jul 25, 2023
Previously, properties were not being stored correctly, so the path for EP 2.0 Auth Scheme resolution was not being hit. After the fix from aws/smithy-go#434 was merged, issues happened in the new code path.
isaiahvita
pushed a commit
that referenced
this pull request
Jul 25, 2023
Previously, properties were not being stored correctly, so the path for EP 2.0 Auth Scheme resolution was not being hit. After the fix from aws/smithy-go#434 was merged, issues happened in the new code path.
isaiahvita
pushed a commit
that referenced
this pull request
Jul 27, 2023
Previously, properties were not being stored correctly, so the path for EP 2.0 Auth Scheme resolution was not being hit. After the fix from aws/smithy-go#434 was merged, issues happened in the new code path.
isaiahvita
pushed a commit
that referenced
this pull request
Jul 31, 2023
Previously, properties were not being stored correctly, so the path for EP 2.0 Auth Scheme resolution was not being hit. After the fix from aws/smithy-go#434 was merged, issues happened in the new code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/codegen/aws-modelsfolder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.N/A
If the PR addresses an existing bug or feature, please reference it here.
Follow-up PR for aws/smithy-go#434
To help speed up the process and reduce the time to merge please ensure that
Allow edits by maintainersis checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.N/A
Previously, properties were not being stored correctly, so the path for EP 2.0 Auth Scheme resolution was not being hit.
After the fix from aws/smithy-go#434 was merged, issues happened in the new code path.
This PR contains fixes (mainly type issues) for the new code path.