convert s3 handle_200_error_test into an actual unit test #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2
lucix-aws
changed the title
isaiahvita
approved these changes
Jul 7, 2023
syall
approved these changes
Jul 7, 2023
Merged
isaiahvita
pushed a commit
to isaiahvita/aws-sdk-go-v2
that referenced
this pull request
Jul 25, 2023
… HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2 (aws#2174)
isaiahvita
pushed a commit
that referenced
this pull request
Jul 25, 2023
… HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2 (#2174)
isaiahvita
pushed a commit
that referenced
this pull request
Jul 27, 2023
… HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2 (#2174)
isaiahvita
pushed a commit
that referenced
this pull request
Jul 31, 2023
… HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2 (#2174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert s3's
handle_200_error_testinto an actual unit test with a fake HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2.