Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws library functions for endpoint rules engine and fix partition generation #2110

Merged
merged 8 commits into from
May 5, 2023

Conversation

isaiahvita
Copy link
Contributor

  • endpoints2.0 needed aws library functions and they dont belong in the smithy-go repository.
  • the partition function needed two different types for "partition config" this is because the default partition config should be guaranteed to always have values so those members needed to be Go value types. but the region overrides needed to be nullable.

@isaiahvita isaiahvita requested a review from a team as a code owner April 27, 2023 01:04
@isaiahvita isaiahvita changed the title Add aws library functions for endpoints2.0 and fix partition generation Add aws library functions for endpoint rules engine and fix partition generation Apr 27, 2023
"af-south-1": {
Name: nil,
DNSSuffix: nil,
DualStackDNSSuffix: nil,
DnsSuffix: nil,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: nil is the default value, we could generate only the overrides and not have to explicitly set them. This would shorten the region maps and make the generated partitions slightly more readable as the overrides would be more clear.

Copy link
Contributor

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on the generated code rather than tracking it down in codegen. Overall looks good.

Fix and ship

service/s3/endpoints.go Outdated Show resolved Hide resolved
service/s3/endpoints.go Outdated Show resolved Hide resolved
service/s3/endpoints.go Show resolved Hide resolved
service/s3/endpoints.go Outdated Show resolved Hide resolved
@isaiahvita isaiahvita merged commit 3a850a8 into aws:ep20 May 5, 2023
@isaiahvita isaiahvita deleted the ep20-provider branch May 5, 2023 23:06
isaiahvita added a commit that referenced this pull request May 12, 2023
isaiahvita added a commit that referenced this pull request May 17, 2023
isaiahvita added a commit that referenced this pull request May 17, 2023
isaiahvita added a commit to isaiahvita/aws-sdk-go-v2 that referenced this pull request Jul 25, 2023
isaiahvita added a commit that referenced this pull request Jul 25, 2023
isaiahvita added a commit that referenced this pull request Jul 27, 2023
isaiahvita added a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants