-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws library functions for endpoint rules engine and fix partition generation #2110
Conversation
isaiahvita
commented
Apr 27, 2023
- endpoints2.0 needed aws library functions and they dont belong in the smithy-go repository.
- the partition function needed two different types for "partition config" this is because the default partition config should be guaranteed to always have values so those members needed to be Go value types. but the region overrides needed to be nullable.
"af-south-1": { | ||
Name: nil, | ||
DNSSuffix: nil, | ||
DualStackDNSSuffix: nil, | ||
DnsSuffix: nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: nil
is the default value, we could generate only the overrides and not have to explicitly set them. This would shorten the region maps and make the generated partitions slightly more readable as the overrides would be more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments on the generated code rather than tracking it down in codegen. Overall looks good.
Fix and ship