Feature/config refactor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SDK adding an external package. This package is resposible for loading external configuration data such as environment and shared config files. In addition this would be the customers initial interface into the SDK loading the SDKs config. Removes session package from the SDK. This update removes the Session type and all of its loading logic. This is all replaced with the external package. The aws.Config type is updated to satisfy the ConfigProvider interface. Flattens the client, metadata, request, and credentials packages into aws.
Renames Credentials: * Valid -> HasKeys * ProviderName -> Source * StaticProvider -> StaticCredentialsProvider * Add CA Bundle injection * Add EC2 Metadata region provider util * Add shared config loading tests.
Corrects the external config loading of credentials so that the EC2 role provider is set first as a fallback. Any other credentials set will override it.
Removing the ConfigProvider interface replacing all usage with `aws.Config`
jasdel
force-pushed
the
feature/ConfigRefactor
branch
from
bbc3a29 to
de990c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the v2 SDK removing the
SessionandConfigProvidertypes. In their place a new packageexternalwas created to provide external configuration loading. Such as Environment and Shared config.This change also flattens the SDK's
request,client,metadata, andcredentialspackages into `aws.