Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove python3.8 from validate tests #7645

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Nov 4, 2024

Which issue(s) does this change fix?

N/A

Why is this change necessary?

python3.8 is going to be deprecated soon, for that reason sam validate tests are failing.

How does it address the issue?

By removing python3.8 runtime from validate tests.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner November 4, 2024 18:35
@mndeveci mndeveci requested review from mildaniel and hnnasit November 4, 2024 18:35
@mndeveci mndeveci enabled auto-merge November 4, 2024 18:38
@mndeveci mndeveci added this pull request to the merge queue Nov 4, 2024
Merged via the queue into aws:develop with commit 20e32a3 Nov 4, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants