Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sam-config.md: replace --config-prefix by --config-env #2736

Merged
merged 6 commits into from
Mar 25, 2021
Merged

sam-config.md: replace --config-prefix by --config-env #2736

merged 6 commits into from
Mar 25, 2021

Conversation

ygorth
Copy link
Contributor

@ygorth ygorth commented Mar 18, 2021

Which issue(s) does this change fix?

Why is this change necessary?

Updates sam-config.md documentation that has a wrong command parameter.

How does it address the issue?

What side effects does this change have?

Better documentation.

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ygorth ygorth changed the title replace --config-prefix by --config-env sam-config.md: replace --config-prefix by --config-env Mar 18, 2021
designs/sam-config.md Outdated Show resolved Hide resolved
@ygorth ygorth requested a review from sriram-mv March 18, 2021 21:04
@moelasmar moelasmar merged commit f5ba707 into aws:develop Mar 25, 2021
elbayaaa pushed a commit to elbayaaa/aws-sam-cli that referenced this pull request Mar 25, 2021
* replace --config-prefix by --config-env

* update previous changelog entry

Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants