fix: --base-dir is disregarded in sam build #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
suggested changes
Mar 16, 2021
| @@ -80,8 +84,8 @@ def __enter__(self) -> "BuildContext": | |||
| "\n".join([f"- {full_path}" for full_path in remote_stack_full_paths]), | |||
| ) | |||
|
|
|||
| self._function_provider = SamFunctionProvider(self.stacks) | |||
| self._layer_provider = SamLayerProvider(self.stacks) | |||
| self._function_provider = SamFunctionProvider(self.stacks, self._use_raw_codeuri) | |||
There was a problem hiding this comment.
Could we add a note here too and reference the issue number.
mndeveci
suggested changes
Mar 16, 2021
mndeveci
approved these changes
Mar 16, 2021
aahung
force-pushed
the
fix-build-dir
branch
2 times, most recently
from
a62c74d to
3ac6120
Compare
sriram-mv
reviewed
Mar 16, 2021
| ChildStackX: | ||
| Type: AWS::Serverless::Application | ||
| Properties: | ||
| Location: ../ChildStackX/template.yaml |
There was a problem hiding this comment.
This will combine with provided base dir right?
There was a problem hiding this comment.
However if a base dir is not provided, we just resolve with location of the template. (which is not this particular test, but asking to help grok through the test)
There was a problem hiding this comment.
yes, whether base dir is provided or not, this Location is resolved according to its parent template path.
There was a problem hiding this comment.
on offline conversation: applies only to codeuri and contenturi.
sriram-mv
approved these changes
Mar 16, 2021
aahung
changed the title
aahung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#2717
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.