v0.7.4-beta #415
v0.7.4-beta #415
Conversation
eladb
commented
Jul 26, 2018
eladb
commented
- Bump to v0.7.4-beta
- Update CHANGELOG
CHANGELOG.md
Outdated
| * VpcNetwork (BREAKING): add the ability customize subnet configurations ([#250]). Subnet allocation was changed to improve IP space efficiency but this forces `VpcNetwork` instances to be replaced | ||
| * A huge shout-out to our first external contributor, [@moofish32], for many | ||
| valuable improvements to the EC2 VPC construct. | ||
| * The `AWS::CDK::Metadata` resource is injected to templates to analyze usage |
There was a problem hiding this comment.
Probably should link to a place were one can see the documentation of what is collected and how to opt out. You don't want eyebrows to raise =)
There was a problem hiding this comment.
Added reference to the issue for now
CHANGELOG.md
Outdated
| * _**BREAKING**_: All AWS libraries renamed from `@aws-cdk/xxx` to | ||
| `@aws-cdk/aws-xxx` in order to avoid conflicts with framework modules | ||
| ([@RomainMuller] in [#384]). | ||
| * _**BREAKING**_: The __@aws-cdk/resources__ module has been deprecated. |
CHANGELOG.md
Outdated
| to all synthesized templates which includes library versions used in the app. | ||
| This allows the CDK team to analyze usage and notify users if they use | ||
| deprecated versions. To opt-out, use the switch `--no-version-reporting` or | ||
| set `version-reporting` to `false` in your `cdk.json` ([@RomainMuller] in |
There was a problem hiding this comment.
Oh that's nice. Possibly the "highlights" entries should somehow link to the detailed wording then? (This complements the previous comment on the same topic)
CHANGELOG.md
Outdated
| * _**BREAKING**_: Add the ability customize subnet configurations. | ||
| Subnet allocation was changed to improve IP space efficiency. `VpcNetwork` | ||
| instances will need to be replaced ([@moofish32] in [#250]) | ||
| * ***BREAKING***: Renamed `Fleet` to `AutoScalingGroup` to align with service |
There was a problem hiding this comment.
There's some inconsistency with how the highlights are done... L64 has _**BREAKING**_, this has ***BREAKING*** - is this intentional?
| ### AWS CodePipeline | ||
|
|
||
| * _**BREAKING**_: Moved CodeCommit and CodeBuild and LambdaInvoke actions from | ||
| the CodePipeline library to `@aws-cdk/aws-xxx-codepipline` modules |
There was a problem hiding this comment.
I wonder if those should be @aws-cdk-codepipeline-xxx instead -- this is what would come to my mind first. Have you discussed this with @skinny85 already?
Related, I kinda think it may be interesting for this entry to mention that this is to avoid introducing dependency cycles, due to this API being pretty densely cross-connected.
There was a problem hiding this comment.
The mental model is that codepipline is the platform and the various services provide plug-ins to it. That's why the first name is the actual service. This also has to do with who owns those constructs.
There was a problem hiding this comment.
That does make sense. Probably worth a documentation entry, though.
| @@ -1,14 +1,137 @@ | |||
| ## [UNRELEASED] | |||
| [@rix0rrr]: https://github.com/rix0rrr | |||
There was a problem hiding this comment.
I'm thinking maybe we want to also have a CONTRIBUTORS file or something. Not necessarily right now, though.
