Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(ecs): machineImageType support AL2023 #32550

Merged
merged 2 commits into from
Dec 17, 2024
Merged

revert(ecs): machineImageType support AL2023 #32550

merged 2 commits into from
Dec 17, 2024
+14 −3,164

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Dec 17, 2024

Reverts #32509 as there's known issue with the flag usage canContainersAccessInstanceRole. We're deprecating this flag usage and should not introduce any new changes to this flag that will cause more users to use it.

@GavinZZ GavinZZ changed the title Revert "feat(ecs): machineImageType support AL2023" revert(ecs): machineImageType support AL2023 Dec 17, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 17, 2024 01:07
@github-actions github-actions bot added the p2 label Dec 17, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 17, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (5e01cc2) to head (df9e715).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32550   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files         108      108           
  Lines        7159     7159           
  Branches     1319     1319           
=======================================
  Hits         5642     5642           
  Misses       1332     1332           
  Partials      185      185
Flag Coverage Δ
suite.unit 78.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.80% <ø> (ø)

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: df9e715
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e8d8237 into main Dec 17, 2024
17 checks passed
@mergify mergify bot deleted the revert-32509-ecs-al2023 branch December 17, 2024 02:10
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samson-keung samson-keung

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GavinZZ @aws-cdk-automation @samson-keung