Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(secretmanager): adding missed header in README #32532

Merged
merged 2 commits into from
Dec 16, 2024
Merged

chore(secretmanager): adding missed header in README #32532

merged 2 commits into from
Dec 16, 2024
+2 −0

Conversation

moelasmar
Copy link
Contributor

This PR is to fix the readme, and add back a header that got deleted by mistake in this PR https://github.com/aws/aws-cdk/pull/26329/files#diff-c70c65923cf81d0d8bdd04d2b6160ec67aa5556be569ac08f44359df53de8bb9

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2024 05:01
@github-actions github-actions bot added the p2 label Dec 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 16, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (2e3b2ac) to head (fb2a5e3).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32532   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files         108      108           
  Lines        7163     7163           
  Branches     1320     1320           
=======================================
  Hits         5643     5643           
  Misses       1335     1335           
  Partials      185      185
Flag Coverage Δ
suite.unit 78.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.77% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 16, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fb2a5e3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a125c24 into main Dec 16, 2024
20 checks passed
@mergify mergify bot deleted the melasmar/fix_secretmanager_readme branch December 16, 2024 15:46
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaizencc kaizencc

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moelasmar @aws-cdk-automation @kaizencc