fix(AdotLambdaLayerPythonSdkVersion): Update latest version mapping #26192
Conversation
|
|
github-actions
bot
added
beginning-contributor
Shiva953
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Although this meets the request in the ticket how do we scale this. There is currently 1.13-1.18 in versions for python and I'm sure there will be more. This will make the code base noisy in having static vars for each version and latest. If that is the pattern in other parts of the code base I can go with it but is there a better approach. Also, a snapshot test should be created if not already there testing LATEST and if not should be added so as new versions get added a test can be run to ensure correct context of latest. Additionally, this addresses Python but should we update the other languages versions as well? |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
2 similar comments
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Description
This PR resolves the issue of the AdotLambdaLayerPythonSdkVersion.html file returning an outdated version (1.13) instead of the expected latest version (1.18.0). The file has been updated to include the correct version mapping for 'LATEST' and ensures that the latest version is retrieved correctly.
Closes #26168
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license