build: fix automated Gitpod dev setup by installing dependencies first #14896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
suggested changes
May 27, 2021
There was a problem hiding this comment.
Thanks so much for the help (again) @jankeromnes!
I'm actually discussing this with @njlynch on how exactly to proceed - I think a better solution would be to stop running check-yarn-lock.js as a a pre-build step.
I will keep you posted!
njlynch
added a commit
that referenced
this pull request
Jun 1, 2021
Having this check in the prebuild is causing issues with the way we set up GitPod integration. Our build step actually does install as well, so our build is really a build+install, so it makes sense to do the check here anyway. fixes #14896
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
Having this check in the prebuild is causing issues with the way we set up GitPod integration. Our build step actually does install as well, so our build is really a build+install, so it makes sense to do the check here anyway. fixes #14896 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Having this check in the prebuild is causing issues with the way we set up GitPod integration. Our build step actually does install as well, so our build is really a build+install, so it makes sense to do the check here anyway. fixes aws#14896 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello AWS friends! 👋
I'm not sure when this broke, but when I open AWS CDK in Gitpod, I now get this error:
I noticed in your
CONTRIBUTING.mdthatyarn installshould be run after cloning the repository. Addingyarn installto theinittask seems to fix this error. 🙌I've also made a few minor drive-by changes:
prebuildsconfig (it's usually near the bottom of.gitpod.yml)dbaeumer.vscode-eslintextension version (no longer needed / unpinned now auto-installs the latest release)Please take a look.