Skip to content

rds: scalability is spelled wrong  #32415

Closed
@mbonig

Description

@mbonig

Describe the bug

In this recent PR:

https://github.com/aws/aws-cdk/pull/32151/files#diff-49b4a9e1bf0b7db3ab71f4f08580da0cb2191d84605dc82a70c324bd122d5cf7

this introduced a new clusterScailabilityType property which is spelled wrong and will cause confusion

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I expected things to be spelled correctly.

Current Behavior

There is a typo, clusterScailabilityType should be clusterScalabilityType

Reproduction Steps

None, it's a typo

Possible Solution

replace all Scailability with Scalability

Additional Information/Context

No response

CDK CLI Version

Framework Version

No response

Node.js Version

OS

Language

TypeScript

Language Version

No response

Other information

No response

Activity

added
bugThis issue is a bug.
needs-triageThis issue or PR still needs to be triaged.
on Dec 7, 2024
pahud

pahud commented on Dec 9, 2024

@pahud
Contributor

Err...Yes we should get it fixed.

added
effort/smallSmall work item – less than a day of effort
and removed
needs-triageThis issue or PR still needs to be triaged.
on Dec 9, 2024
mazyu36

mazyu36 commented on Dec 10, 2024

@mazyu36
Contributor

@badmintoncryer
FYI.
Sorry, I also missed this during the review​​​​​​​​​​​​​​​​.

badmintoncryer

badmintoncryer commented on Dec 10, 2024

@badmintoncryer
Contributor

@mazyu36 Thanks! Of all things, I messed up with the argument name... I'm sorry @mbonig 😭

@pahud Is this a breaking change? Or should I add the correct name property and make the old property deprecated?

self-assigned this
on Jan 9, 2025

8 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

@aws-cdk/aws-rdsRelated to Amazon Relational DatabasebugThis issue is a bug.effort/smallSmall work item – less than a day of effortgood first issueRelated to contributions. See CONTRIBUTING.mdp2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    rds: scalability is spelled wrong · Issue #32415 · aws/aws-cdk