-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MISRA Compliance Updates #71
Merged
Merged
+64
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the 8.7 rule to the misra.config file. Small changes to casts in an if statement and an addition/subtraction for MISRA compliance. Added in the DNDEBUG and DISABLE_LOGGING when building the coverity_analysis target.
jasonpcarroll
previously approved these changes
Aug 30, 2022
AniruddhaKanhere
requested changes
Aug 30, 2022
AniruddhaKanhere
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change please
Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com>
jasonpcarroll
approved these changes
Aug 30, 2022
AniruddhaKanhere
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the MISRA.md file to match the new format for it.
Added the 8.7 rule to the misra.config file.
Small changes to casts in an if statement and an addition/subtraction
for MISRA compliance.
Added in the DNDEBUG and DISABLE_LOGGING when building the
coverity_analysis target.
Added coverity to the lexicon
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.