MBS-11834 [Instrumentation plugin] add instrumentation.environment k8s config #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsvoronin
changed the title
dsvoronin
force-pushed
the
MBS-11834-k8s-config
branch
3 times, most recently
from
5d1200c to
6c08636
Compare
instead of implicit gradle parameters "default" config added for backward compatibility
dsvoronin
force-pushed
the
MBS-11834-k8s-config
branch
from
6c08636 to
ac72363
Compare
sboishtyan
reviewed
Nov 12, 2021
| |} | ||
| | | ||
| | environments { | ||
| | register<com.avito.instrumentation.configuration.KubernetesViaContext>("k8sContext") { |
There was a problem hiding this comment.
It will be simpler for users If they can write
environments {
kubernetesViaContext("name") { }
... etc
}
sboishtyan
reviewed
Nov 12, 2021
| /** | ||
| * todo remove (registered for backward compatibility) | ||
| */ | ||
| private fun registerDefaultEnvironment( |
There was a problem hiding this comment.
When do you plan to remove default env?
There was a problem hiding this comment.
Right after CISteps removal, because almost every build uses instrumentation tasks, which uses default environment for now; so in a couple of days
| when (environment) { | ||
| is KubernetesViaCredentials -> | ||
| task.kubernetesCredentials.set( | ||
| KubernetesCredentials.Service( |
There was a problem hiding this comment.
Looks like we want to reuse those models
There was a problem hiding this comment.
I'm not sure that we need to reuse models for gradle public API,
if it will be covered by proposed dsl abstraction: #1265 (comment) then yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of implicit gradle parameters
"default" config added for backward compatibility