Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAMS] Adapt for new Response.t #120

Merged
merged 4 commits into from
Mar 21, 2018
Merged

[CAMS] Adapt for new Response.t #120

merged 4 commits into from
Mar 21, 2018

Conversation

oyeb
Copy link
Contributor

@oyeb oyeb commented Feb 9, 2018 •
edited
Loading

  • Refactored ResponseHandler
    • Removed unnecessary one-liners which avoids unnecessary appends.
    • Used better variable and function names.
    • CAMS now parses AVS and CVV response - that was missing till now.
    • CAMS always returned an :ok tuple! Fixed that. (Look at the old tests)
  • Added reason to Resonse.t in cases of error.
  • Removes unnecessary parse clause.

@oyeb oyeb added this to the 1.1.0 milestone Feb 9, 2018
@oyeb oyeb self-assigned this Feb 9, 2018
@oyeb oyeb requested a review from gopalshimpi February 9, 2018 08:13
oyeb added 4 commits March 20, 2018 23:17
@oyeb
Refactored ResponseHandler, updated Response.t
fa079f4 
* Removed unnecessary one-liners.
* Used better variable names.
* CAMS now parses AVS and CVV response - that was missing till now.
* **CAMS always returned an :ok tuple!** Fixed that. (Look at the old
tests)
@oyeb
Added reason to Resonse.t in cases of error.
d5c4ad8
@oyeb
Removes unnecessary parse clause.
7192d0b
@oyeb
Mock tests shouldn't use gringotts.ex
fea679e
@oyeb oyeb force-pushed the cams-response_t branch from 0f09277 to fea679e Compare March 20, 2018 17:49
@ashish173 ashish173 merged commit a91deec into dev Mar 21, 2018
@ashish173 ashish173 deleted the cams-response_t branch March 21, 2018 11:55
ashish173 pushed a commit that referenced this pull request Apr 22, 2018
@oyeb @ashish173
[CAMS] Adapt for new Response.t (#120)
6285c75 
* Refactored ResponseHandler, updated Response.t
* CAMS now parses AVS and CVV response - that was missing till now.
* Removes unnecessary `parse` clause.
* Mock tests shouldn't use gringotts.ex
ashish173 pushed a commit that referenced this pull request Apr 22, 2018
@oyeb @ashish173
[CAMS] Adapt for new Response.t (#120)
30d1260 
* Refactored ResponseHandler, updated Response.t
* CAMS now parses AVS and CVV response - that was missing till now.
* Removes unnecessary `parse` clause.
* Mock tests shouldn't use gringotts.ex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish173 ashish173 ashish173 approved these changes

@gopalshimpi gopalshimpi Awaiting requested review from gopalshimpi

Assignees

@oyeb oyeb

Labels
enhancement
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@oyeb @ashish173