Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lidar_centerpoint): rework parameters #822

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 25, 2024

Description

See autowarefoundation/autoware.universe#6167

Tests performed

See autowarefoundation/autoware.universe#6167

Effects on system behavior

See autowarefoundation/autoware.universe#6167

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review January 25, 2024 02:55
@kminoda kminoda changed the title chore(lidar_centerpoint): use config chore(lidar_centerpoint): rework parameters Jan 25, 2024
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 2eeb90e into autowarefoundation:main Feb 6, 2024
8 of 10 checks passed
@kminoda kminoda deleted the chore/lidar_centerpoint/use_config branch February 6, 2024 02:06
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants