refactor(tier4_localization_component): input_pointcloud param added #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This was referenced Jul 29, 2023
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 3, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 3, 2023
chore: sync awf/autoware_launch
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Oct 23, 2023
* ci: add workflow to comment on PR Signed-off-by: Tomohito Ando <antm678@gmail.com> * style(pre-commit): autofix * update comment Signed-off-by: Tomohito Ando <antm678@gmail.com> * trigger only when opened Signed-off-by: Tomohito Ando <antm678@gmail.com> * update comment Signed-off-by: Tomohito Ando <antm678@gmail.com> * update comment Signed-off-by: Tomohito Ando <antm678@gmail.com> * chore: remove redundant double quotation Signed-off-by: TomohitoAndo <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <antm678@gmail.com> Signed-off-by: TomohitoAndo <tomohito.ando@tier4.jp> Co-authored-by: TomohitoAndo <TomohitoAndo@users.noreply.github.com>
rej55
pushed a commit
to rej55/autoware_launch
that referenced
this pull request
Jul 10, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds input/pointcloud parameter to tier4_localization_component.launch.xml from https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_localization_launch/launch/localization.launch.xml and https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_localization_launch/launch/pose_twist_estimator/pose_twist_estimator.launch.xml. Also parameter renamed to input_pointcloud for the sake of keeping namespace simplicity in autoware_launch.
Related: autowarefoundation/autoware.universe#4411
Tests performed
İt worked without error on logging simulator.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.