Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization_launch): add camera & vector map based localization #3749

Closed

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented May 18, 2023

Description

YabLoc(カメラとベクターマップでの位置推定)を利用するする機能を追加します。
YabLocはuniverse/externalに配置され、ここではそれを呼び出すためのlaunchファイルのみを追加しています。

Related links

Dicussion: https://github.com/orgs/autowarefoundation/discussions/3484

Tests performed

次の2件を確認しました。

  • デフォルトではNDTが従来通り実行されること。
  • YabLocモードで起動したときに、カメラベース位置推定が実行されること。

Notes for reviewers

動作確認をする場合は次の2件を確認するといいです。

  • デフォルトではNDTが従来通り実行されること。
  • YabLocモードで起動したときに、カメラベース位置推定が実行されること。

Interface changes

autoware_launch

  • autoware_launchにyabloc_localization_component.launch.xmlが増えました。
  • autoware_launch/config/localizationにyablocディレクトリが増えました。

autoware.universe

  • pose_initializerにyabloc moduleが増えました。
    • pose_initializerのパラメータにyabloc_enabledが増えました。
    • pose_initializerのyamlファイルは複数あり、その全てにyabloc_enabledを追加しました。
  • yabloc_localization_launch packageを追加しました。

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

KYabuuchi added 12 commits May 31, 2023 10:09
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi force-pushed the feature/yabloc_integration branch from f3ead3d to 1e12b41 Compare May 31, 2023 01:09
@KYabuuchi
Copy link
Contributor Author

I will merge YabLoc in other way.

@KYabuuchi KYabuuchi closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant