Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase duplicate run detection to 3 minutes #687

Conversation

notnarb
Copy link

@notnarb notnarb commented Jan 27, 2023

  • This is a hacky workaround to handle older hardware which will send duplicate udev events over 2 minutes after the initial drive event.

Fixes #678

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Debian 10
  • Debian 11
  • Docker
  • Other (Please state here)

Checklist:

  • I have submitted this PR against the v2_devel branch (Unless the main branch has a security issue)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

 * This is a hacky workaround to handle older hardware which will send duplicate
   udev events over 2 minutes after the initial drive event.

Fixes automatic-ripping-machine#678
@notnarb notnarb force-pushed the feature/increase-duplicate-window branch from 6441452 to dabb2ca Compare January 27, 2023 08:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@microtechno9000 microtechno9000 merged commit fcd6858 into automatic-ripping-machine:v2_devel Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants