Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMUI split out of routes into blueprints #686

Merged

Conversation

microtechno9000
Copy link
Collaborator

@microtechno9000 microtechno9000 commented Jan 26, 2023

Description

Separation of the ARMUI routes into blueprints for easier management of the code. Blueprints have been created as below. No change to the ARMUI code or functionality within this PR, other than Flake8 QA fixes and incorporation of existing PRs.

Related to #589

  • covering the armui not the ripper code

New blueprints:

auth covers

  • user_loader [..]
  • unauthorized_handler [GET]
  • login [GET, POST]
  • logout [GET]
  • update_password [GET, POST]

database covers

  • database [GET]
  • dbupdate [POST]
  • import_movies [JSON]

history covers

  • history [GET]

jobs covers

  • jobdetail [GET]
  • titlesearch [GET]
  • custometitle [GET]
  • gettitle / customtitle [GET]
  • updatetitle [GET]
  • activerips [GET]
  • changeparams [GET]
  • list_titles [GET]
  • json [JSON GET]

logs covers

  • logs [GET]
  • listlogs [GET]
  • logreader [GET]

sendmovies covers

  • send_movies [GET]

settings (PR #650) covers

  • settings [GET]
  • save_settings [POST]
  • save_ui_settings [POST]
  • save_abcde_settings [POST]
  • save_apprise_cfg [POST]
  • systeminfo [POST]
  • systemdrivescan [GET]
  • update_arm [POST]
  • drive_eject [GET]

Fixes # nil

Type of change

Please delete options that are not relevant.

  • code clean up

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Debian 10
  • Debian 11
  • Docker
  • Other (Please state here)

Checklist:

  • I have submitted this PR against the v2_devel branch (Unless the main branch has a security issue)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

elif mode == "full":
generate = ui_utils.generate_full_log(full_path)
elif mode == "download":
return send_file(full_path, as_attachment=True)

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
@microtechno9000 microtechno9000 changed the title V2 devel ARMUI spit out of routes into blueprints Jan 26, 2023
@microtechno9000 microtechno9000 changed the title ARMUI spit out of routes into blueprints ARMUI split out of routes into blueprints Jan 27, 2023
@microtechno9000
Copy link
Collaborator Author

microtechno9000 commented Jan 27, 2023

DVD rip completed, found an error in the title search. needed a reference to the route_jobs
added that in, otherwise no issues with DVD job, log attached.

56680D4.log

@shitwolfymakes shitwolfymakes self-requested a review January 28, 2023 09:15
@shitwolfymakes shitwolfymakes added the enhancement New feature request/PR label Jan 28, 2023
@shitwolfymakes
Copy link
Member

Docker BR rip successful, see attached log.
MOULIN_ROUGE.log

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shitwolfymakes shitwolfymakes merged commit edbce05 into automatic-ripping-machine:v2_devel Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants